Colors and Bug Fix

[rahly@terrygoodkind.net]

Found a bug in rtorrent (at least with remoting with putty) where if the canvas isn't in multiples of 3's it would mess up the bottom of the of the "window" by combining lines.

Also hardcoded colors in, Bright Green text for finished torrents, and bright red for "open" torrents, which are torrents that have been started but not finished. This is not the same as running torrents.

Patch is included.

[rahly@terrygoodkind.net]

Fix + Colors

[rahly@terrygoodkind.net]

Added new patch for customability. Now you can specify the color you wish active torrents and done torrents to be in the .rtorrent.rc file

new entries include

done_fg_color done_bg_color active_fg_color active_bg_color

using a value of -1 for any color will use the terminals default color

Colors are the same for curses

0 = black 1 = red 2 = green 3 = yellow 4 = blue 5 = magenta 6 = cyan 7 = white

patch also includes previous fix

[rahly@terrygoodkind.net]

Oh yeah, also set the list so that the torrent title is bold if

A) done and upload rate > 0 B) active and download rate > 0

otherwise if there isn't activity, the torrent appears without bold

[rahly@terrygoodkind.net]

patch works for current SVN as well

[Klav]

Works great (using SVN), thanks!

[anonymous]

i'm loving it and have been using it since it was posted here :) (with 0.7.9)

thanks!

[anonymous]

works with 0.8.3

[rahly]

updated patch for SVN

[anonymous]

how to apply this patch on 0.8.4 rev 1087

[anonymous]

Download the patch, save it in the rtorrent source directory

Quote: patch -p1 < rtorrent-0.8.4-SVN-canvas-fix.patch

The result should be

Quote: patching file src/command_network.cc Hunk #1 succeeded at 368 (offset 40 lines). patching file src/display/canvas.cc Hunk #1 succeeded at 91 (offset 14 lines). patching file src/display/window_download_list.cc patching file src/display/window_download_list.h patching file src/ui/download_list.cc Hunk #1 succeeded at 136 with fuzz 2 (offset 16 lines). patching file src/ui/download_list.h patching file src/ui/element_download_list.h Hunk #1 succeeded at 59 with fuzz 2. patching file src/ui/root.cc Hunk #1 succeeded at 43 (offset 1 line). Hunk #2 succeeded at 65 (offset 1 line). Hunk #3 succeeded at 101 (offset 1 line). Hunk #4 succeeded at 246 with fuzz 2 (offset 1 line). patching file src/ui/root.h Hunk #1 succeeded at 81 (offset 2 lines). Hunk #2 succeeded at 110 (offset 2 lines).

If it is, recompile. If it's not, you've probably screwed up your sources, redownload them.

[anonymous]

is there a way not only to hightlight active torrents?

[rahly]

its possible to highlight other things, but why would you want to highlight non active torrents? what would that criteria entail?

[sleip]

patch to use reverse video on the main window download list instead of "*" for selected item

[sleip]

that reverse video patch is like #58 but works only with rahlys patch.

[anonymous]

Could you attach a screenshoot?

[rahly]

Quick screenshot, showing the 5 color states.

1. closed
2. Seeding(have all the file) and actively uploading
3. not downloaded and stalled(not actively downloading)
4. actively downloading
5. Seeding by not actively uploading.

[anonymous]

Thanks!

[anonymous]

Replying to anonymous:

Thanks!

Remember though, the colors themselves, are configurable.

[Rahly]

the 0.8.4 patch works with the unstable 0.8.5 code. I couldn't get it to work with the latest svn, but then again, i couldn't even compile it without the patch. When the svn is back to working, it should work with it, that i've seen.

[Rahly]

Works with the latest SVN, must have been fixed.

[nao.nakashima@gmail.com]

With 0.8.4 patch only bolds active seeding torrents, don`t see any color.

[Rahly]

you need to set the colors in the configuration. please read the messages. Default is to use current colors.

my configuration options are as followed:

done_fg_color = 2
active_fg_color = 1

[Rahly]

make sure you put that in your ~/.rtorrent.rc

[sleip]

updated rahlys patch to 0.8.6

[Rahly]

Wow, nice, no code changes, but it looks like he moved quite a bit of functions around so the patcher failed. Lovely ;-)

[alexei]

@Rahly, patcher fails in what version? For me, patch worked correctly for 0.8.6 source. Nice patch, by the way!

[anonymous]

Replying to alexei:

@Rahly, patcher fails in what version? For me, patch worked correctly for 0.8.6 source. Nice patch, by the way!

Oooops, never mind. I see what you mean. Sorry about stupid questions.

[calico@noichi.net]

I tried latest patch for 0.86 on changeset 1145, and I can't compile rtorrent. Here is the output error :

make[3]: Entering directory `/root/svn/rtorrent/src/display' g++ -DHAVE_CONFIG_H -I. -I../.. -I. -I./.. -I../.. -g -O2 -g -DDEBUG -I/usr/include/sigc++-2.0 -I/usr/lib/sigc++-2.0/include -I/usr/local/include -I/usr/local/include -I/usr/local/include -MT window_download_list.o -MD -MP -MF .deps/window_download_list.Tpo -c -o window_download_list.o window_download_list.cc window_download_list.cc: In member function 'virtual void display::WindowDownloadList::redraw()': window_download_list.cc:104: error: 'class torrent::Download' has no member named 'up_rate' window_download_list.cc:109: error: 'class torrent::Download' has no member named 'is_active' window_download_list.cc:110: error: 'class torrent::Download' has no member named 'down_rate' make[3]: *** [window_download_list.o] Error 1 make[3]: Leaving directory `/root/svn/rtorrent/src/display'

Someone have an idea ?

Thanks a lot.

[hyper_ch]

Canvas Color Patch designed for rev. 1163

[hyper_ch]

of course many thanks go to the original author and to rakshasa's patience with a couple of problems I had adjusting it to rev. 1163

[anonymous]

would be kind of nice to have to added to the main branch, so we wouldn't have to keep rebuilding the patch

[Carol <caroll@yahoo.com>]

This bug should be fixed through  writing services.

[anonymous]

Nice to share your experience. And the bug seems to be in good use.  http://www.astrabeds.com/latex-mattresses.html

[placement argent]

Thanks for taking the time to discuss this, I feel strongly about information and love learning more on this. If possible, as you gain expertise, It is extremely helpful for me. would you mind updating your blog with more information?  http://placementargent.org

[betclic]

I think a nice blog  http://www.paris-sports.info/betclic.html

[anonymous]

Thanks for the fine tips and posting..

[nfl jerseys]

Alisan Ghase is a retired NFL player who now owns a NFL Jerseys website:  http://www.stajump.com

[anonymous]

of course many thanks go to the original author and to rakshasa's patience with a couple of problems I had adjusting it to rev. 1163  http://www.highdesign.ro/

[xbox live cards]

I came to your article from another article and am really interested in this learning about this. , I feel strongly about information and love learning more on this. If possible, as you gain expertise, It is extremely helpful for me.  http://www.pcgamesupply.com/buy/Xbox-Live-3-Month-Gold-Card-Code

[hammock chair stand]

She seems to be missing in these days. I never heard of her recently. Don't tell me she's quit.  http://www.esleepmasters.com/Hammock_Chair_Stands_s/1869.htm

[robin]

This article gives the light in which we can observe the reality. This is very nice one and gives in depth information. Thanks for this nice article. Good post.....Valuable information for all.  carpet cleaner Monterey