Interface and color patch

[karabaja4]

I made some modifications to rtorrent interface to make it suit my preference, and I have been told that submitting the patch upstream would be good a idea, so here goes :)

Screenshot:  http://karabaja.pondi.hr/packages/rtorrent-mod/shot.png

[karabaja4]

patch file

[Artifex Maximus <artifex@freemail.hu>]

Very nice! :-)

[anonymous]

Will that patch work with the IPFilter patch of ticket #239 and the GeoIP patch of ticket #2064 on patching rtorrent 0.8.6 stable? Looks really great though!

[karabaja4]

It should work, I don't think it affects the same files. It was reported that it patches cleanly on top of Arch Linux rtorrent-extended AUR package if you discard the included color patches ( http://aur.archlinux.org/packages.php?ID=33756) - check the patches listed there.

[chay]

Doesn't work with 1164

chay@phenom:trunk$ patch -p0 < rtorrent-mod.patch patching file rtorrent/src/display/canvas.cc patching file rtorrent/src/display/utils.cc Hunk #2 succeeded at 56 with fuzz 1 (offset 1 line). Hunk #3 succeeded at 104 (offset 1 line). Hunk #4 FAILED at 135. Hunk #5 succeeded at 257 with fuzz 1 (offset 1 line). Hunk #6 succeeded at 268 (offset 1 line). Hunk #7 succeeded at 293 (offset 1 line). 1 out of 7 hunks FAILED -- saving rejects to file rtorrent/src/display/utils.cc.rej patching file rtorrent/src/display/utils.h patching file rtorrent/src/display/window_download_list.cc patching file rtorrent/src/display/window_title.cc patching file rtorrent/src/ui/download_list.cc Hunk #1 FAILED at 220. 1 out of 1 hunk FAILED -- saving rejects to file rtorrent/src/ui/download_list.cc.rej

[karabaja4]

Sorry, I used stable 0.8.6 to make the patch. Obviously trunk sources are a bit different.

[klif-e]

hmmm didn't work for 0.8.6 stable for me, clean extract of 0.8.6 and then ran 'patch -p0 < rtorrent-mod.patch' and got failures

patching file rtorrent-0.8.6/src/display/canvas.cc Hunk #1 FAILED at 92. patching file rtorrent-0.8.6/src/display/utils.cc Hunk #1 FAILED at 34. Hunk #2 FAILED at 52. Hunk #3 FAILED at 96. Hunk #4 FAILED at 127. Hunk #5 FAILED at 219. Hunk #6 FAILED at 230. Hunk #7 FAILED at 255. patching file rtorrent-0.8.6/src/display/utils.h Hunk #1 FAILED at 66. patching file rtorrent-0.8.6/src/display/window_download_list.cc Hunk #1 FAILED at 34. Hunk #2 FAILED at 81. patching file rtorrent-0.8.6/src/display/window_title.cc Hunk #1 FAILED at 48. patching file rtorrent-0.8.6/src/ui/download_list.cc Hunk #1 FAILED at 220.

[anonymous]

combined with patch from http://libtorrent.rakshasa.no/ticket/1382. Bold printing for seeding torrents, customizable colors etc.

[anonymous]

Would it be possible to add something like:

"error_fg_color" and "error_bg_color" to the patch? I've no experience with either C/C++ coding and I'm not familiar with the lib/rtorrent code, so I just throw in my thoughts. But it's a nice patch already!

[anonymous]

Would it be possible to modify the original patch (rtorrent-mod.patch), so that torrents with errors (f.e. tracker not reachable, or error message from tracker) get colored, say, red? And maybe show active torrents with traffic in, say, blue; so one could discriminate them from active, but for some reason stalled (no seeds ...) torrents?

Thanks!

[do.it@i.ua]

#1382 seems to be gone - could someone provide a description of how to configure custom colours? I've got a list of configurable colours (done_fg_color, done_bg_color, active_fg_color, active_bg_color), but am not sure about their possible values - 6-digit colour codes?

[do.it@i.ua]

It appears that colours are 1 (red), 2 (yellow), 3 (green)

[do.it@i.ua]

when tested, 1=red, 2=green, 3=yellowish

[do.it@i.ua]

If anyone needs an amd64 rtorrent 0.8.6 package for Debian Squeeze, integrating #239 (ipfilter), #2171 (mod-canvas) and #2064 (GeoIP) - I made one, but can't post a direct link (hit the spam blocker). Try searching for "rtorrent-enhanced-with-ipfilter-and-geoip-debian-squeeze-amd64-package".

[pyroscope]

And yet another color patch, with decent configuration commands...

http :pyroscope.googlecode.com/svn/trunk/pyrocore/docs/rtorrent-extended/patches/ (ui_pyroscope.*)

Docs at http :code.google.com/p/pyroscope/wi ki/RtorrentExtended